Allow Maven deployment to fail#11756
Open
sarahchen6 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10f13a0ee9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Allow Maven Central deployment job to fail.
The result of this change is that the
verify_maven_central_deploymentjob that depends ondeploy_to_maven_centralwill run as long asdeploy_to_maven_centralcompletes. Without this change, theverify_maven_central_deploymentjob only runs ifdeploy_to_maven_centralsucceeds.Motivation
With the
1.63.1patch release, pipeline failures resulted in the successful publishing of artifacts onto Maven Central but not of OCI images. Also, OCI image publishing is gated via apublishing-jobthat is gated by Maven Central deployment verification.After fixing the pipeline issue, we wanted to re-run the pipeline and override the Maven Central deployment verification to allow the OCI publishing. This should be possible with the manually triggered
override_verify_maven_centraljob, but sincedeploy_to_maven_centralfailed (release already exists),verify_maven_central_deploymentcould never run.By allowing the deployment to fail and the verification to run regardless, the override should now work.
Additional Notes
If the override job is not run and the initial deployment fails, the verification would run and still fail as well, still properly gating the
publishing-gate.The Maven Central publishing jobs only run on protected git tags.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]